Commit 79c4d89f authored by ArchanaKumari01's avatar ArchanaKumari01
Browse files

Merge remote-tracking branch 'upstream/release-1.8' into page-section

parents bb92a022 c2820917
master Dark_theme SB-25589 SB-28090 aws_fileRead contributions dependabot/npm_and_yarn/src/app/client/decode-uri-component-0.2.2 dependabot/npm_and_yarn/src/app/decode-uri-component-0.2.2 dependabot/npm_and_yarn/src/app/express-4.17.3 dependabot/npm_and_yarn/src/app/jsonwebtoken-9.0.0 dependabot/npm_and_yarn/src/desktop/OpenRAP/decode-uri-component-0.2.2 dependabot/npm_and_yarn/src/desktop/OpenRAP/express-4.17.3 dependabot/npm_and_yarn/src/desktop/OpenRAP/jsonwebtoken-9.0.0 dependabot/npm_and_yarn/src/desktop/OpenRAP/qs-6.5.3 dependabot/npm_and_yarn/src/desktop/decode-uri-component-0.2.2 dependabot/npm_and_yarn/src/desktop/express-4.17.3 dependabot/npm_and_yarn/src/desktop/jsonwebtoken-9.0.0 dependabot/npm_and_yarn/src/desktop/qs-6.10.3 desktop-common-consumption filters_5.1.1 gcp gcp_test keshavprasadms-patch-1 keshavprasadms-patch-2 release-1.12 release-1.13 release-1.13.1 release-1.13.2 release-1.13.4 release-1.14 release-1.14-SP-2 release-1.14-sp3 release-1.14.6 release-1.15 release-1.15.1 release-1.8.1 release-2.0.0 release-2.0.0-hotfix release-2.0.1 release-2.0.2 release-2.0.3 release-2.1.0 release-2.1.1 release-2.10.0 release-2.10.1 release-2.10.2 release-2.10.3 release-2.2.0 release-2.2.1 release-2.3.0 release-2.3.1 release-2.3.5 release-2.3.6 release-2.4.0 release-2.4.1 release-2.4.2 release-2.5.0 release-2.5.1 release-2.6.0 release-2.6.0-loadtest release-2.6.5 release-2.6.6 release-2.7.0 release-2.8.0 release-2.8.1 release-2.8.10 release-2.8.11 release-2.8.12 release-2.8.2 release-2.8.3 release-2.8.4 release-2.8.5 release-2.8.6 release-2.8.7 release-2.8.8 release-2.8.9 release-2.9.0 release-3.0 release-3.0-merge release-3.0.0 release-3.0.1 release-3.0.2 release-3.0.3 release-3.0.4 release-3.0.4-sso release-3.1.0 release-3.1.1 release-3.1.2 release-3.2.0 release-3.2.1 release-3.2.10 release-3.2.11 release-3.2.12 release-3.2.13 release-3.2.14 release-3.2.2 release-3.2.3 release-3.2.4 release-3.3.0 release-3.3.0-telemetry-fix release-3.3.1 release-3.3.2 release-3.4.0 release-3.4.1 release-3.4.2 release-3.4.3 release-3.4.4 release-3.4.5 release-3.4.6 release-3.4.7 release-3.5.0 release-3.5.1 release-3.5.2 release-3.5.3 release-3.6.0 release-3.6.1 release-3.6.5 release-3.6.6 release-3.7.0 release-3.7.1 release-3.7.2 release-3.8.0 release-3.8.1 release-3.8.2 release-3.8.3 release-3.9.0 release-3.9.1 release-3.9.2 release-3.9.3 release-4.0.0 release-4.0.1 release-4.0.2 release-4.1 release-4.1.0 release-4.1.1 release-4.10.0 release-4.10.0.1 release-4.10.1 release-4.10.2 release-4.10.2.1 release-4.10.2.2 release-4.10.3 release-4.2.0 release-4.2.1 release-4.3.0 release-4.3.1 release-4.4.0 release-4.4.1 release-4.5.0 release-4.5.1 release-4.5.2 release-4.6.0 release-4.7.0 release-4.7.1 release-4.8.0 release-4.8.5 release-4.9.0 release-4.9.1 release-5.0.0 release-5.0.0.1 release-5.0.0.2 release-5.0.0.3 release-5.0.1 release-5.0.2 release-5.1.0 release-5.1.1 release-sonarcloud revert-3718-copypi revert-3842-release-2.8.7 revert-3890-release-2.8.9 revert-4427-player-cache-issue revert-4537-SB-19763 revert-5244-sh-809 revert-5260-SB-table-3.3.0 revert-8284-release-5.0.0 sharathkashyap-patch-1 Tags unavailable
No related merge requests found
Showing with 19 additions and 19 deletions
+19 -19
......@@ -156,9 +156,9 @@ export class DataDrivenFilterComponent implements OnInit, OnDestroy {
(data: ServerResponse) => {
this.formFieldProperties = data;
_.forEach(this.formFieldProperties, (formFieldCategory) => {
if (formFieldCategory && formFieldCategory.allowedUsers) {
const userRoles = formFieldCategory.allowedUsers.filter(element => this.userRoles.includes(element));
if (!this.showField(formFieldCategory.allowedUsers)) {
if (formFieldCategory && formFieldCategory.allowedRoles) {
const userRoles = formFieldCategory.allowedRoles.filter(element => this.userRoles.includes(element));
if (!this.showField(formFieldCategory.allowedRoles)) {
this.formFieldProperties.splice(this.formFieldProperties.indexOf(formFieldCategory), 1);
}
}
......@@ -247,9 +247,9 @@ export class DataDrivenFilterComponent implements OnInit, OnDestroy {
}
}
showField(allowedUsers) {
if (allowedUsers) {
return this.permissionService.checkRolesPermissions(allowedUsers);
showField(allowedRoles) {
if (allowedRoles) {
return this.permissionService.checkRolesPermissions(allowedRoles);
} else {
return true;
}
......
......@@ -43,7 +43,7 @@ describe('UserUploadComponent', () => {
't0037': 'Password: Unique or common password given by organization',
't0038': `All other columns are optional. These columns include information about the user such as:`,
't0039': 'Phone',
't0040': `Role: User's role on DIKSHA. Examples for this column:
't0040': `Role: User's role on sunbird. Examples for this column:
CONTENT_CREATOR, CONTENT_REVIEWER, FLAG_REVIEWER, COURSE_MENTOR, ORG_ADMIN, SYSTEM_ADMINISTRATION, COURSE_ADMIN, COURSE_CREATOR`,
't0041': `Grade: Classes taught by the user`,
't0042': `Location: User's place of location of the user`,
......
......@@ -3,7 +3,7 @@ export const eventData = {
'context': {
'channel': '01231711180382208027',
'pdata': {
'id': 'staging.diksha.portal',
'id': 'staging.sunbird.portal',
'ver': '1.5.1',
'pid': 'sunbird-portal'
},
......
......@@ -3,7 +3,7 @@ export const eventData = {
'context': {
'channel': '01231711180382208027',
'pdata': {
'id': 'staging.diksha.portal',
'id': 'staging.sunbird.portal',
'ver': '1.5.1',
'pid': 'sunbird-portal'
},
......
......@@ -3,7 +3,7 @@ export const eventData = {
'context': {
'channel': '01231711180382208027',
'pdata': {
'id': 'staging.diksha.portal',
'id': 'staging.sunbird.portal',
'ver': '1.5.1',
'pid': 'sunbird-portal'
},
......
......@@ -3,7 +3,7 @@ export const eventData = {
'context': {
'channel': '01231711180382208027',
'pdata': {
'id': 'staging.diksha.portal',
'id': 'staging.sunbird.portal',
'ver': '1.5.1',
'pid': 'sunbird-portal'
},
......
......@@ -136,7 +136,7 @@ describe('UpForReviewComponent', () => {
userService._userData$.next({ err: null, userProfile: mockUserRoles });
spyOn(component, 'getContentType').and.callThrough();
const returnContentType = component.getContentType().contentType;
const ContentType = ['Collection', 'TextBook', 'Course', 'LessonPlan', 'Resource'];
const ContentType = ['Collection', 'Course', 'LessonPlan', 'Resource'];
expect(returnContentType).toEqual(ContentType);
}));
});
......
......@@ -2,7 +2,7 @@
"name": "player",
"author": "sunbird",
"version": "1.8.0",
"buildNumber": "6",
"buildNumber": "8",
"private": true,
"devDependencies": {
"chai": "^4.1.2",
......
......@@ -491,7 +491,7 @@ t0036=UserName: The unique name assigned to the user by the organization. Ensure
t0037=Password: Unique or common password given by organization
t0038=All other columns are optional. These columns include information about the user such as:
t0039=Phone
t0040=Role: User’s role on DIKSHA. Examples for this column: CONTENT_CREATOR, CONTENT_REVIEWER, FLAG_REVIEWER, COURSE_MENTOR, ORG_ADMIN, SYSTEM_ADMINISTRATION, COURSE_ADMIN, COURSE_CREATOR
t0040=Role: User’s role. Examples for this column: CONTENT_CREATOR, CONTENT_REVIEWER, FLAG_REVIEWER, COURSE_MENTOR, ORG_ADMIN, SYSTEM_ADMINISTRATION, COURSE_ADMIN, COURSE_CREATOR
t0041=Grade: Classes taught by the user
t0042=Location: User\u2019s place of location of the user
t0043=DOB: User\u2019s date of birth, the value should be entered in DD-MM-YYYY format
......
......@@ -490,7 +490,7 @@ t0036=UserName: The unique name assigned to the user by the organization.Ensure
t0037=Password: Unique or common password given by organization
t0038=All other columns are optional. These columns include information about the user such as:
t0039=Phone
t0040=Role: User’s role on DIKSHA. Examples for this column: CONTENT_CREATOR, CONTENT_REVIEWER, FLAG_REVIEWER, COURSE_MENTOR, ORG_ADMIN, SYSTEM_ADMINISTRATION, COURSE_ADMIN, COURSE_CREATOR
t0040=Role: User’s role. Examples for this column: CONTENT_CREATOR, CONTENT_REVIEWER, FLAG_REVIEWER, COURSE_MENTOR, ORG_ADMIN, SYSTEM_ADMINISTRATION, COURSE_ADMIN, COURSE_CREATOR
t0041=Grade: Classes taught by the user
t0042=Location: User\u2019s place of location of the user
t0043=DOB: User\u2019s date of birth, the value should be entered in DD-MM-YYYY format
......
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.
This diff is collapsed.
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment